Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap all invocations of npm in node to set the PATH appropriately #123

Merged
merged 2 commits into from
May 6, 2024

Conversation

asinghvi17
Copy link
Collaborator

Fix #122

@korsbo, could you test this PR out and see if it works?

@korsbo
Copy link

korsbo commented May 3, 2024

I'll try, but I only trigger this error on CI and, for some reason, it does not trigger consistently, so it'll take longer to test than I have time for today (daycare closes soon).

@korsbo
Copy link

korsbo commented May 6, 2024

It seems to work! I've tried triggering the bug a few times on my CI setup where the original issue came from. The problem has been a bit inconsistent before, but I've tried with this PR enough times for it to be unlikely for the streak of CI passes to be a fluke. 🎉

@asinghvi17 asinghvi17 merged commit 70aa87d into master May 6, 2024
2 checks passed
thofma pushed a commit to thofma/DocumenterVitepress.jl that referenced this pull request May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mismatch between npm and node
2 participants